Re: [PATCH v2 12/33] block: Unify bdrv_child_cb_detach()

[Eric Blake]

On 2/4/20 11:08 AM, Max Reitz wrote:
> Make bdrv_child_cb_detach() call bdrv_backing_detach() for children with
> a COW role (and drop the reverse call from bdrv_backing_detach()), so it
> can be used for any child (with a proper role set).
>
> Because so far no child has a proper role set, we need a temporary new
> callback for child_backing.detach that ensures bdrv_backing_detach() is
> called for all COW children that do not have their role set yet.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   block.c | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)

Looks oddly familiar after 11/33 :)
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org