[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments
Date: Thu, 6 Feb 2020 13:18:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/6/20 11:24 AM, Kamil Rytarowski wrote:
On 03.02.2020 12:54, Philippe Mathieu-Daudé wrote:
@@ -2029,6 +2072,19 @@ static void qemu_whpx_start_vcpu(CPUState *cpu)

+static void qemu_nvmm_start_vcpu(CPUState *cpu)
+    char thread_name[VCPU_THREAD_NAME_SIZE];
+    cpu->thread = g_malloc0(sizeof(QemuThread));
+    cpu->halt_cond = g_malloc0(sizeof(QemuCond));

Nitpick, we prefer g_new0().

In this file other qemu_*_start_vcpu() use  g_malloc0().

I will leave this part unchanged and defer tor future style fixups if
someone is interested.

Fair enough.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]