qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 27/29] tests/acceptance/migration: Default to -nodefaults


From: Thomas Huth
Subject: Re: [PATCH v2 27/29] tests/acceptance/migration: Default to -nodefaults
Date: Thu, 6 Feb 2020 17:03:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote:
> We don't need the default options to run this test.
> 
> This fixes errors when running a binary built with
> --without-default-devices such:
> 
>   ERROR: qemu-system-arm: Unsupported NIC model: virtio-net-pci
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  tests/acceptance/migration.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
> index a44c1ae58f..d09e5d3fe7 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -32,10 +32,12 @@ class Migration(Test):
>  
>  
>      def test_migration_with_tcp_localhost(self):
> -        source_vm = self.get_vm()
>          dest_uri = 'tcp:localhost:%u' % self._get_free_port()
>          dest_vm = self.get_vm('-incoming', dest_uri)
> +        dest_vm.add_args('-nodefaults')
>          dest_vm.launch()
> +        source_vm = self.get_vm()
> +        source_vm.add_args('-nodefaults')
>          source_vm.launch()
>          source_vm.qmp('migrate', uri=dest_uri)
>          wait.wait_for(
> 

Reviewed-by: Thomas Huth <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]