[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/4] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 co
From: |
Guenter Roeck |
Subject: |
[PATCH v2 4/4] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command |
Date: |
Thu, 6 Feb 2020 10:32:19 -0800 |
The Linux kernel recently started using FAST_READ_4 commands.
This results in flash read failures. At the same time, the m25p80
emulation is seen to read 8 more bytes than expected. Adjusting the
expected number of dummy cycles to match FAST_READ fixes the problem.
Fixes: f95c4bffdc4c ("aspeed/smc: snoop SPI transfers to fake dummy cycles")
Reviewed-by: Cédric Le Goater <address@hidden>
Signed-off-by: Guenter Roeck <address@hidden>
---
v2: No change
hw/ssi/aspeed_smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 23c8d2f062..0444570750 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -787,11 +787,11 @@ static int aspeed_smc_num_dummies(uint8_t command)
case FAST_READ:
case DOR:
case QOR:
+ case FAST_READ_4:
case DOR_4:
case QOR_4:
return 1;
case DIOR:
- case FAST_READ_4:
case DIOR_4:
return 2;
case QIOR:
--
2.17.1
- [PATCH v2 1/4] m25p80: Convert to support tracing, Guenter Roeck, 2020/02/06
- [PATCH v2 2/4] m25p80: Improve command handling for Jedec commands, Guenter Roeck, 2020/02/06
- [PATCH v2 3/4] m25p80: Improve command handling for unsupported commands, Guenter Roeck, 2020/02/06
- [PATCH v2 4/4] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command,
Guenter Roeck <=
- Re: [PATCH v2 1/4] m25p80: Convert to support tracing, Philippe Mathieu-Daudé, 2020/02/06
- Re: [PATCH v2 1/4] m25p80: Convert to support tracing, Alistair Francis, 2020/02/06
- Re: [PATCH v2 1/4] m25p80: Convert to support tracing, Cédric Le Goater, 2020/02/07
- Re: [PATCH v2 1/4] m25p80: Convert to support tracing, Cédric Le Goater, 2020/02/17