qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 25/46] tests/acceptance/migration: Factor out assert_migration()


From: Philippe Mathieu-Daudé
Subject: [PULL 25/46] tests/acceptance/migration: Factor out assert_migration()
Date: Thu, 6 Feb 2020 22:19:15 +0100

From: Oksana Vohchana <address@hidden>

We are going to reuse this code when testing different transport
methods, so factor it out first

Signed-off-by: Oksana Vohchana <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[PMD: Split patch in 2, reworded subject and description]
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
 tests/acceptance/migration.py | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index a44c1ae58f..3db733b1ce 100644
--- a/tests/acceptance/migration.py
+++ b/tests/acceptance/migration.py
@@ -24,6 +24,16 @@ class Migration(Test):
     def migration_finished(vm):
         return vm.command('query-migrate')['status'] in ('completed', 'failed')
 
+    def assert_migration(self, src_vm, dst_vm):
+        wait.wait_for(self.migration_finished,
+                      timeout=self.timeout,
+                      step=0.1,
+                      args=(src_vm,))
+        self.assertEqual(src_vm.command('query-migrate')['status'], 
'completed')
+        self.assertEqual(dst_vm.command('query-migrate')['status'], 
'completed')
+        self.assertEqual(dst_vm.command('query-status')['status'], 'running')
+        
self.assertEqual(src_vm.command('query-status')['status'],'postmigrate')
+
     def _get_free_port(self):
         port = network.find_free_port()
         if port is None:
@@ -38,13 +48,4 @@ class Migration(Test):
         dest_vm.launch()
         source_vm.launch()
         source_vm.qmp('migrate', uri=dest_uri)
-        wait.wait_for(
-            self.migration_finished,
-            timeout=self.timeout,
-            step=0.1,
-            args=(source_vm,)
-        )
-        self.assertEqual(dest_vm.command('query-migrate')['status'], 
'completed')
-        self.assertEqual(source_vm.command('query-migrate')['status'], 
'completed')
-        self.assertEqual(dest_vm.command('query-status')['status'], 'running')
-        self.assertEqual(source_vm.command('query-status')['status'], 
'postmigrate')
+        self.assert_migration(source_vm, dest_vm)
-- 
2.21.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]