[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/20] target/arm: Tidy msr_mask

From: Peter Maydell
Subject: Re: [PATCH v3 09/20] target/arm: Tidy msr_mask
Date: Fri, 7 Feb 2020 17:40:09 +0000

On Mon, 3 Feb 2020 at 14:47, Richard Henderson
<address@hidden> wrote:
> The CPSR_USER mask for IS_USER already avoids all of the RES0
> bits as per aarch32_cpsr_valid_mask.  Fix up the formatting.

CPSR_USER includes CPSR_Q and CPSR_GE, which might be RES0
depending on feature bit settings.

Diff made a bit of a mess of this patch -- I think it would
be easier to understand if the reformatting to add {} was
separate from the code change.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]