[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/migration: Add some slack to auto converge

From: Juan Quintela
Subject: Re: [PATCH] tests/migration: Add some slack to auto converge
Date: Tue, 11 Feb 2020 09:34:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> There's an assert in autoconverge that checks that we quit the
> iteration when we go below the expected threshold.  Philippe
> saw a case where this assert fired with the measured value
> slightly over the threshold. (about 3k out of a few million).
> I can think of two reasons:
>   a) Rounding errors
>   b) That after we make the decision to quit iteration we do one
>     more sync and that sees a few more dirty pages.
> So add 1% slack to the assertion, that should cover a and
> most cases of b, probably all we'll see for the test.
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

It shouldn't matter really.  And if we are seeing that problem.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]