Re: [PATCH v2 01/30] configure: Allow user to specify sphinx-build binary

[Peter Maydell]

On Fri, 14 Feb 2020 at 12:20, Markus Armbruster <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
> >>  # Default objcc to clang if available, otherwise use CC
> >> @@ -4803,7 +4816,7 @@ has_sphinx_build() {
> >>      # sphinx-build doesn't exist at all or if it is too old.
> >>      mkdir -p "$TMPDIR1/sphinx"
> >>      touch "$TMPDIR1/sphinx/index.rst"
> >> -    $sphinx_build -c "$source_path/docs" -b html "$TMPDIR1/sphinx" 
> >> "$TMPDIR1/sphinx/out" >/dev/null 2>&1
> >> +    "$sphinx_build" -c "$source_path/docs" -b html "$TMPDIR1/sphinx" 
> >> "$TMPDIR1/sphinx/out" >/dev/null 2>&1
> >>  }
> >
> > This change isn't related to trying sphinx-build-3 --
> > did you actually need it ?
>
> If the for loop finds nothing, $sphinx_build remains empty.  Quoting the
> variable seems cleaner.

Oh, I see. Anyway, yes, happy to have quotes here.

thanks
-- PMM