qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bul


From: Peter Maydell
Subject: Re: [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists
Date: Fri, 14 Feb 2020 15:48:35 +0000

On Fri, 14 Feb 2020 at 15:46, Markus Armbruster <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
>
> > On Fri, 14 Feb 2020 at 14:23, Markus Armbruster <address@hidden> wrote:
> >> What's the rationale for the split between
> >>
> >>     [PATCH v2 13/30] qapi/block-core.json: Use explicit bulleted lists
> >>     [PATCH v2 14/30] qapi/ui.json: Use explicit bulleted lists
> >>     [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit 
> >> bulleted lists
> >>
> >> ?
> >
> > Just keeping down the size of individual patches for ease of
> > review. ui.json and block-core.json both had enough uses that
> > needed fixing to feel like reasonably patch-sized amounts. This
> > patch is all the straggler files, none of which had numerous
> > enough changes to seem worth splitting further.
>
> I see.
>
> Separating block.json and block-core.json is a bit odd.
>
> Mind if I squash all three?

I don't mind; the split was as I say mostly just to keep
commit sizes down, so if all-squashed-together works better
for you as a reviewer feel free.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]