[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/7] commit: Fix argument order for block_job_error_action()
From: |
Kevin Wolf |
Subject: |
[PATCH 3/7] commit: Fix argument order for block_job_error_action() |
Date: |
Fri, 14 Feb 2020 21:08:08 +0100 |
The block_job_error_action() error call in the commit job gives the
on_err and is_read arguments in the wrong order. Fix this.
(Of course, hard-coded is_read = false is wrong, too, but that's a
separate problem for a separate patch.)
Signed-off-by: Kevin Wolf <address@hidden>
---
block/commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/commit.c b/block/commit.c
index cce898a4f3..8189f079d2 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -182,7 +182,7 @@ static int coroutine_fn commit_run(Job *job, Error **errp)
}
if (ret < 0) {
BlockErrorAction action =
- block_job_error_action(&s->common, false, s->on_error, -ret);
+ block_job_error_action(&s->common, s->on_error, false, -ret);
if (action == BLOCK_ERROR_ACTION_REPORT) {
goto out;
} else {
--
2.20.1
- [PATCH 0/7] commit: Expose on-error option in QMP, Kevin Wolf, 2020/02/14
- [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for jobs, Kevin Wolf, 2020/02/14
- [PATCH 2/7] commit: Remove unused bytes_written, Kevin Wolf, 2020/02/14
- [PATCH 4/7] commit: Inline commit_populate(), Kevin Wolf, 2020/02/14
- [PATCH 3/7] commit: Fix argument order for block_job_error_action(),
Kevin Wolf <=
- [PATCH 5/7] commit: Fix is_read for block_job_error_action(), Kevin Wolf, 2020/02/14
- [PATCH 6/7] commit: Expose on-error option in QMP, Kevin Wolf, 2020/02/14
- [PATCH 7/7] iotests: Test error handling policies with block-commit, Kevin Wolf, 2020/02/14