[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 13/79] arm/digic_boards: use memdev for RAM

From: Richard Henderson
Subject: Re: [PATCH v5 13/79] arm/digic_boards: use memdev for RAM
Date: Mon, 17 Feb 2020 10:51:36 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/17/20 9:33 AM, Igor Mammedov wrote:
> memory_region_allocate_system_memory() API is going away, so
> replace it with memdev allocated MemoryRegion. The later is
> initialized by generic code, so board only needs to opt in
> to memdev scheme by providing
>   MachineClass::default_ram_id
> and using MachineState::ram instead of manually initializing
> RAM memory region.
> PS:
>  remove no longer needed DigicBoardState
> PS2:
>  while at it add check for user supplied RAM size and error
>  out if it mismatches board expected value.
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Andrew Jones <address@hidden>
> ---
> v3:
>   * move 'DigicState *s' declaration to the top of digic4_board_init()
> v2:
>   * fix format string causing build failure on 32-bit host
>     (Philippe Mathieu-Daudé <address@hidden>)

Reviewed-by: Richard Henderson <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]