[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 34/79] arm/xilinx_zynq: drop RAM size fixup

From: Richard Henderson
Subject: Re: [PATCH v5 34/79] arm/xilinx_zynq: drop RAM size fixup
Date: Mon, 17 Feb 2020 11:23:00 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/17/20 9:34 AM, Igor Mammedov wrote:
> If user provided non-sense RAM size, board will complain and
> continue running with max RAM size supported.
> Also RAM is going to be allocated by generic code, so it won't be
> possible for board to fix things up for user.
> Make it error message and exit to force user fix CLI,
> instead of accepting non-sense CLI values.
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Alistair Francis <address@hidden>
> ---

Reviewed-by: Richard Henderson <address@hidden>

> +    /* max 2GB ram */
> +    if (machine->ram_size > 0x80000000) {
> +        error_report("RAM size more than %d is not supported", 0x80000000);
> +        exit(EXIT_FAILURE);
> +    }

If you have occasion to re-spin, I think that a common function like

void machine_memory_check_max_size(MachineState *machine,
                                   ram_addr_t max);

akin to the machine_memory_check_fixed_size I proposed earlier, would help keep
the language consistent across the boards.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]