Re: [PATCH v3 03/33] block: Add BdrvChildRole and BdrvChildRoleBits

[Eric Blake]

On 2/18/20 6:42 AM, Max Reitz wrote:
> This mask will supplement BdrvChildClass when it comes to what role (or
> combination of roles) a child takes for its parent.  It consists of
> BdrvChildRoleBits values (which is an enum).
>
> Because empty enums are not allowed, let us just start with it filled.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   include/block/block.h | 38 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)

> +
> +/* Mask of BdrvChildRoleBits values */
> +typedef unsigned int BdrvChildRole;
> +

I like how it turned out (both the additional comments earlier on, and 
the typedef for documentation purposes).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org