[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pcie_root_port: Add disable_hotplug option

From: Julia Suvorova
Subject: Re: [PATCH] pcie_root_port: Add disable_hotplug option
Date: Tue, 18 Feb 2020 19:40:03 +0100

On Tue, Feb 18, 2020 at 6:18 PM Laine Stump <address@hidden> wrote:
> On 2/18/20 11:17 AM, Julia Suvorova wrote:
> > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt
> > to manage it and restrict unplug for the entire machine. This is going
> > to prevent user-initiated unplug in guests (Windows mostly).
> > Usage:
> >      -device pcie-root-port,disable-hotplug=true,...
> Double negatives (e.g. "disable-hotplug=false") tend to confuse simple
> minds like mine. Would it be any more difficult to make the name of the
> option positive instead (e.g. "enable-hotplug") with the default set to
> "true"?

disable-hotplug=false will not be used, because it's default. And it
follows previous naming (''disable-acs').

Best regards, Julia Suvorova.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]