[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/9] hw/display/artist: Delay some variables initialization
From: |
Richard Henderson |
Subject: |
[PULL 3/9] hw/display/artist: Delay some variables initialization |
Date: |
Tue, 18 Feb 2020 11:39:23 -0800 |
From: Philippe Mathieu-Daudé <address@hidden>
We want to have an early exit path. Delay some initializations
before the variables are used.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Sven Schnelle <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/display/artist.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 47f0e9f0bc..97c811b35e 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -558,7 +558,7 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
bool update_start, int skip_pix, int max_pix)
{
struct vram_buffer *buf;
- uint8_t color = artist_get_color(s);
+ uint8_t color;
int dx, dy, t, e, x, y, incy, diago, horiz;
bool c1;
uint8_t *p;
@@ -569,10 +569,6 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
s->vram_start = (x2 << 16) | y2;
}
- buf = &s->vram_buffer[ARTIST_BUFFER_AP];
-
- c1 = false;
-
if (x2 > x1) {
dx = x2 - x1;
} else {
@@ -583,6 +579,8 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
} else {
dy = y1 - y2;
}
+
+ c1 = false;
if (dy > dx) {
t = y2;
y2 = x2;
@@ -620,6 +618,8 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
x2, int y2,
}
x = x1;
y = y1;
+ color = artist_get_color(s);
+ buf = &s->vram_buffer[ARTIST_BUFFER_AP];
do {
if (c1) {
--
2.20.1
- [PULL 0/9] target/hppa patch queue, Richard Henderson, 2020/02/18
- [PULL 1/9] hw/display/artist: Move trace event to draw_line(), Richard Henderson, 2020/02/18
- [PULL 2/9] hw/display/artist: Remove pointless initialization, Richard Henderson, 2020/02/18
- [PULL 3/9] hw/display/artist: Delay some variables initialization,
Richard Henderson <=
- [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display, Richard Henderson, 2020/02/18
- [PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389), Richard Henderson, 2020/02/18
- [PULL 6/9] hw/hppa/dino: Add comments with register name, Richard Henderson, 2020/02/18
- [PULL 7/9] hw/hppa/dino: Fix reg800_keep_bits overrun (CID 1419387 1419393 1419394), Richard Henderson, 2020/02/18
- [PULL 8/9] hw/hppa/dino: Fix bitmask for the PCIROR register, Richard Henderson, 2020/02/18
- [PULL 9/9] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c, Richard Henderson, 2020/02/18
- Re: [PULL 0/9] target/hppa patch queue, Peter Maydell, 2020/02/20