[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389)
From: |
Richard Henderson |
Subject: |
[PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389) |
Date: |
Tue, 18 Feb 2020 11:39:25 -0800 |
From: Philippe Mathieu-Daudé <address@hidden>
Coverity reports:
*** CID 1419388: Control flow issues (DEADCODE)
/hw/display/artist.c: 739 in draw_line_xy()
733 if (endy < 0) {
734 endy = 0;
735 }
736
737
738 if (endx < 0) {
>>> CID 1419388: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
739 return;
740 }
741
742 if (endy < 0) {
743 return;
744 }
*** CID 1419389: Control flow issues (DEADCODE)
/hw/display/artist.c: 743 in draw_line_xy()
737
738 if (endx < 0) {
739 return;
740 }
741
742 if (endy < 0) {
>>> CID 1419389: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
743 return;
744 }
745
746 trace_artist_draw_line(startx, starty, endx, endy);
747 draw_line(s, startx, starty, endx, endy, false, -1, -1);
748 }
Fixes: Covertiy CID 1419388 and 1419389 (commit 4765384ce33)
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Sven Schnelle <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/display/artist.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 5492079116..753dbb9a77 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -734,15 +734,6 @@ static void draw_line_xy(ARTISTState *s, bool update_start)
endy = 0;
}
-
- if (endx < 0) {
- return;
- }
-
- if (endy < 0) {
- return;
- }
-
draw_line(s, startx, starty, endx, endy, false, -1, -1);
}
--
2.20.1
- [PULL 0/9] target/hppa patch queue, Richard Henderson, 2020/02/18
- [PULL 1/9] hw/display/artist: Move trace event to draw_line(), Richard Henderson, 2020/02/18
- [PULL 2/9] hw/display/artist: Remove pointless initialization, Richard Henderson, 2020/02/18
- [PULL 3/9] hw/display/artist: Delay some variables initialization, Richard Henderson, 2020/02/18
- [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display, Richard Henderson, 2020/02/18
- [PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389),
Richard Henderson <=
- [PULL 6/9] hw/hppa/dino: Add comments with register name, Richard Henderson, 2020/02/18
- [PULL 7/9] hw/hppa/dino: Fix reg800_keep_bits overrun (CID 1419387 1419393 1419394), Richard Henderson, 2020/02/18
- [PULL 8/9] hw/hppa/dino: Fix bitmask for the PCIROR register, Richard Henderson, 2020/02/18
- [PULL 9/9] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c, Richard Henderson, 2020/02/18
- Re: [PULL 0/9] target/hppa patch queue, Peter Maydell, 2020/02/20