qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 79/79] tests:numa-test: use explicit memdev to specify nod


From: Igor Mammedov
Subject: Re: [PATCH v5 79/79] tests:numa-test: use explicit memdev to specify node RAM
Date: Wed, 19 Feb 2020 15:30:22 +0100

On Wed, 19 Feb 2020 15:06:24 +0100
Philippe Mathieu-Daudé <address@hidden> wrote:

> On 2/19/20 2:00 PM, Igor Mammedov wrote:
> > On Tue, 18 Feb 2020 18:51:34 +0100
> > Philippe Mathieu-Daudé <address@hidden> wrote:
> >   
> >> On 2/17/20 6:34 PM, Igor Mammedov wrote:  
> >>> Follow up patches will remove automatic RAM distribution
> >>> between nodes and will make default machine types require
> >>> "memdev" option instead of legacy "mem" option.  
> >>
> >> Can we keep this patch for the follow up?  
> > memdev for numa was there for along time, just untested.
> > With this all numa tests switch to it instead of using
> > legacy option (+ a test for legacy option).
> > I don't think the patch should delayed along with numa
> > cleanups.  
> 
> I guess what confuses me is "Follow up patches *will* remove..."
I'll drop this frase since there aren't immediate "Follow up patches"
to avoid confusion

> > 
> > It of-cause could be posted as standalone patch as well,
> > I'll leave it upto Paolo whether to merge it or not.
> >     
> >>>
> >>> Make tests to follow new rules and add an additional test
> >>> for legacy "mem" option on old machine type, to make sure
> >>> it won't regress in the future.
> >>>
> >>> Signed-off-by: Igor Mammedov <address@hidden>
> >>> Acked-by: Thomas Huth <address@hidden>
> >>> ---  
> >>  
> >   
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]