[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] pcie_root_port: Add enable_hotplug option

From: Ján Tomko
Subject: Re: [PATCH v2] pcie_root_port: Add enable_hotplug option
Date: Wed, 19 Feb 2020 16:15:59 +0100

On Wed, Feb 19, 2020 at 03:55:40PM +0100, Julia Suvorova wrote:
Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt
manage it and restrict unplug for the whole machine. This is going to
prevent user-initiated unplug in guests (Windows mostly).
Hotplug is enabled by default.
   -device pcie-root-port,enable-hotplug=false,...

If you want to disable hot-unplug on some downstream ports of one
switch, disable hot-unplug on PCIe Root Port connected to the upstream
port as well as on the selected downstream ports.

Discussion related:

Signed-off-by: Julia Suvorova <address@hidden>
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04868.html

   * change name of the option to 'enable-hotplug' [Laine]
   * change order of enabling capability bits [Igor]
   * enable HPS bit [Igor]
   * add option to xio3130_downstream [Ján]

hw/pci-bridge/pcie_root_port.c     |  3 ++-
hw/pci-bridge/xio3130_downstream.c |  3 ++-
hw/pci/pcie.c                      | 11 +++++++----
include/hw/pci/pcie.h              |  2 +-
include/hw/pci/pcie_port.h         |  1 +
5 files changed, 13 insertions(+), 7 deletions(-)

Reviewed-by: Ján Tomko <address@hidden>


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]