[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/6] tools/virtiofsd/passthrough_ll: Remove unneeded variable assi
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 3/6] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment |
Date: |
Fri, 21 Feb 2020 13:25:33 +0000 |
From: Philippe Mathieu-Daudé <address@hidden>
Fix warning reported by Clang static code analyzer:
CC tools/virtiofsd/passthrough_ll.o
tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is
never read
newfd = -1;
^ ~~
tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' is
never read
newfd = -1;
^ ~~
Fixes: 7c6b66027
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Ján Tomko <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
tools/virtiofsd/passthrough_ll.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index e9e71d5fc2..02ff01fad0 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent,
const char *name,
inode = lo_find(lo, &e->attr);
if (inode) {
close(newfd);
- newfd = -1;
} else {
inode = calloc(1, sizeof(struct lo_inode));
if (!inode) {
@@ -939,7 +938,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent,
const char *name,
inode->nlookup = 1;
inode->fd = newfd;
- newfd = -1;
inode->key.ino = e->attr.st_ino;
inode->key.dev = e->attr.st_dev;
pthread_mutex_init(&inode->plock_mutex, NULL);
--
2.24.1
- [PULL 0/6] virtiofs queue, Dr. David Alan Gilbert (git), 2020/02/21
- [PULL 1/6] virtiofsd: Help message fix for 'seconds', Dr. David Alan Gilbert (git), 2020/02/21
- [PULL 2/6] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment, Dr. David Alan Gilbert (git), 2020/02/21
- [PULL 4/6] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header::error value, Dr. David Alan Gilbert (git), 2020/02/21
- [PULL 3/6] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment,
Dr. David Alan Gilbert (git) <=
- [PULL 6/6] docs: Fix virtiofsd.1 location, Dr. David Alan Gilbert (git), 2020/02/21
- [PULL 5/6] virtiofsd: Remove fuse.h and struct fuse_module, Dr. David Alan Gilbert (git), 2020/02/21
- Re: [PULL 0/6] virtiofs queue, Peter Maydell, 2020/02/21