[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precop
From: |
Peter Xu |
Subject: |
Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy |
Date: |
Fri, 21 Feb 2020 11:35:44 -0500 |
On Fri, Feb 21, 2020 at 11:19:58AM +0100, David Hildenbrand wrote:
[...]
> Lol, man this code is confusing.
(Yes in many places it is...)
>
> So, migration_is_idle() really only checks current_migration, not
> current_incoming.
>
> I didn't expect to be knees deep in migration code at this point ...
>
> if (migration_is_idle()) {
> return:
> }
Yes this seems to work too for postcopy, though may worth add a
comment showing the fact... Thanks,
--
Peter Xu
Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy, Dr. David Alan Gilbert, 2020/02/21
[PATCH v1 08/13] migrate/ram: Simplify host page handling in ram_load_postcopy(), David Hildenbrand, 2020/02/19
[PATCH v1 09/13] migrate/ram: Consolidate variable reset after placement in ram_load_postcopy(), David Hildenbrand, 2020/02/19
[PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy(), David Hildenbrand, 2020/02/19