qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mma


From: no-reply
Subject: Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode
Date: Fri, 21 Feb 2020 15:34:31 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap 
base address in qemu user mode
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
38a7b04 linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base 
address in qemu user mode

=== OUTPUT BEGIN ===
ERROR: consider using qemu_strtoul in preference to strtoul
#23: FILE: linux-user/main.c:341:
+    mmap_base = strtoul(arg, NULL, 0);

total: 1 errors, 0 warnings, 50 lines checked

Commit 38a7b049a7f8 (linux-user: Add an argument QEMU_MMAP_BASE to set custom 
mmap base address in qemu user mode) has style problems, please review.  If any 
of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]