[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 1/8] migration: fix COLO broken caused by a previous commit
From: |
zhanghailiang |
Subject: |
[PATCH V2 1/8] migration: fix COLO broken caused by a previous commit |
Date: |
Mon, 24 Feb 2020 14:54:07 +0800 |
This commit "migration: Create migration_is_running()" broke
COLO. Becuase there is a process broken by this commit.
colo_process_checkpoint
->colo_do_checkpoint_transaction
->migrate_set_block_enabled
->qmp_migrate_set_capabilities
It can be fixed by make COLO process as an exception,
Maybe we need a better way to fix it.
Cc: Juan Quintela <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
---
migration/migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 8fb68795dc..06d1ff9d56 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -865,7 +865,6 @@ bool migration_is_running(int state)
case MIGRATION_STATUS_DEVICE:
case MIGRATION_STATUS_WAIT_UNPLUG:
case MIGRATION_STATUS_CANCELLING:
- case MIGRATION_STATUS_COLO:
return true;
default:
--
2.21.0
- [PATCH V2 0/8] Optimize VM's downtime while do checkpoint in COLO, zhanghailiang, 2020/02/24
- [PATCH V2 1/8] migration: fix COLO broken caused by a previous commit,
zhanghailiang <=
- [PATCH V2 5/8] ram/colo: only record bitmap of dirty pages in COLO stage, zhanghailiang, 2020/02/24
- [PATCH V2 3/8] savevm: Don't call colo_init_ram_cache twice, zhanghailiang, 2020/02/24
- [PATCH V2 2/8] migration/colo: wrap incoming checkpoint process into new helper, zhanghailiang, 2020/02/24
- [PATCH V2 6/8] migration: recognize COLO as part of activating process, zhanghailiang, 2020/02/24
- [PATCH V2 8/8] migration/colo: Only flush ram cache while do checkpoint, zhanghailiang, 2020/02/24
- [PATCH V2 7/8] COLO: Migrate dirty pages during the gap of checkpointing, zhanghailiang, 2020/02/24