Re: [PATCH v31 20/22] Add rx-softmmu

[Eric Blake]

On 2/24/20 9:15 AM, Philippe Mathieu-Daudé wrote:
> On 2/24/20 4:11 PM, Eric Blake wrote:
> > On 2/23/20 12:51 AM, Yoshinori Sato wrote:
> > > Tested-by: Philippe Mathieu-Daudé <address@hidden>
> > > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > > Signed-off-by: Yoshinori Sato <address@hidden>
> > > Message-Id: <address@hidden>
> > > Signed-off-by: Richard Henderson <address@hidden>
> > > pick ed65c02993 target/rx: Add RX to SysEmuTarget
> > > pick 01372568ae tests: Add rx to machine-none-test.c
> > > [PMD: Squashed patches from Richard Henderson modifying
> > >        qapi/common.json and tests/machine-none-test.c]
> > > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > > ---
> >
> > > +++ b/qapi/machine.json
> > > @@ -26,7 +26,7 @@
> > >     'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 
> > > 'lm32',
> > >                'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64',
> > >                'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc',
> > > -             'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4',
> > > +             'ppc64', 'riscv32', 'riscv64', 'rx', 's390x', 'sh4',
> >
> > Missing mention of the new enum member with a 'since 5.0' designation 
> > in the documentation.
>
> Is this something we can automate? Maybe dumping all the qapi data when 
> we do a release, then check the differences before the next release?

Probably. It's already easy to automate a dump of qmp introspection data 
from an arbitrary commit, and diffing the output between the previous 
commit release point and the current proposed release should be 
technically possible.  Our QAPI generator also generates the docs, which 
means it can be enhanced to denote which doc elements are tagged to 
which versions.  Might make a good GSOC project.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org