[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iotests: Fix cleanup path in some tests
From: |
Eric Blake |
Subject: |
Re: [PATCH] iotests: Fix cleanup path in some tests |
Date: |
Mon, 24 Feb 2020 12:25:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/24/20 11:16 AM, Max Reitz wrote:
Some iotests leave behind some external data file when run for qcow2
with -o data_file. Fix that.
Signed-off-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/085 | 1 +
tests/qemu-iotests/087 | 6 ++++++
tests/qemu-iotests/279 | 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)
I'd LOVE for someone to take on a GSOC project to finish the work Jeff
Cody once proposed on having iotests run each test in its own dedicated
directory, such that files are left behind on failure for easy
investigation, and cleanup is a snap of just deleting that directory on
success.
But until then, adding manual cleanup where we missed it is correct.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org