Re: [PATCH 1/2] hw/arm/gumstix: Simplify since the machines are little-endian only

[Peter Maydell]

On Sun, 23 Feb 2020 at 23:10, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> From: Philippe Mathieu-Daudé <address@hidden>
>
> As the Connex and Verdex machines only boot in little-endian,
> we can simplify the code.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---

>  static void gumstix_machine_init(void)
>  {
> +    if (target_words_bigendian()) {
> +        return;
> +    }

I don't think we really need to do this, do we? We don't
in any of the other arm boards that just assume little-endian.
I think TARGET_WORDS_BIGENDIAN will only be true on Arm for
the BE linux-user targets, never for softmmu.

Also, there's a warning comment in the header file for
the declaration of target_words_bigendian() that says
you probably don't want to use it...

If you drop this, then otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM