[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/13] block/stream: Remove redundant statement in stream_run
From: |
John Snow |
Subject: |
Re: [PATCH 01/13] block/stream: Remove redundant statement in stream_run() |
Date: |
Tue, 25 Feb 2020 16:49:35 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/24/20 9:09 PM, address@hidden wrote:
> From: Chen Qun <address@hidden>
>
> Clang static code analyzer show warning:
> block/stream.c:186:9: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> Cc: John Snow <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: address@hidden
> ---
> block/stream.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/stream.c b/block/stream.c
> index 5562ccbf57..d78074ac80 100644
> --- a/block/stream.c
> +++ b/block/stream.c
> @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
> break;
> }
> }
> - ret = 0;
>
> /* Publish progress */
> job_progress_update(&s->common.job, n);
>
Reviewed-by: John Snow <address@hidden>
- Re: [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), (continued)
- [PATCH 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write(), kuhn.chenqun, 2020/02/24
- [PATCH 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v(), kuhn.chenqun, 2020/02/24
- [PATCH 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), kuhn.chenqun, 2020/02/24
- [PATCH 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32(), kuhn.chenqun, 2020/02/24
- [PATCH 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command(), kuhn.chenqun, 2020/02/24
- [PATCH 12/13] usb/hcd-ehci: Remove redundant statements, kuhn.chenqun, 2020/02/24
- [PATCH 01/13] block/stream: Remove redundant statement in stream_run(), kuhn.chenqun, 2020/02/24
- Re: [PATCH 01/13] block/stream: Remove redundant statement in stream_run(),
John Snow <=
- [PATCH 02/13] block/iscsi:Remove redundant statement in iscsi_open(), kuhn.chenqun, 2020/02/24
- [PATCH 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update(), kuhn.chenqun, 2020/02/24
- [PATCH 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write(), kuhn.chenqun, 2020/02/24
- [PATCH 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), kuhn.chenqun, 2020/02/24
- [PATCH 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), kuhn.chenqun, 2020/02/24