[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/19] tests/rcutorture: better document locking of stats
From: |
Alex Bennée |
Subject: |
[PULL 03/19] tests/rcutorture: better document locking of stats |
Date: |
Wed, 26 Feb 2020 07:39:13 +0000 |
This is pure code motion with no functional effect.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
diff --git a/tests/rcutorture.c b/tests/rcutorture.c
index e8b2169e7dd..256d24ed5ba 100644
--- a/tests/rcutorture.c
+++ b/tests/rcutorture.c
@@ -65,8 +65,6 @@
#include "qemu/rcu.h"
#include "qemu/thread.h"
-long long n_reads = 0LL;
-long n_updates = 0L;
int nthreadsrunning;
#define GOFLAG_INIT 0
@@ -78,11 +76,20 @@ static volatile int goflag = GOFLAG_INIT;
#define RCU_READ_RUN 1000
#define NR_THREADS 100
-static QemuMutex counts_mutex;
static QemuThread threads[NR_THREADS];
static struct rcu_reader_data *data[NR_THREADS];
static int n_threads;
+/*
+ * Statistical counts
+ *
+ * These are the sum of local counters at the end of a run.
+ * Updates are protected by a mutex.
+ */
+static QemuMutex counts_mutex;
+long long n_reads = 0LL;
+long n_updates = 0L;
+
static void create_thread(void *(*func)(void *))
{
if (n_threads >= NR_THREADS) {
@@ -230,8 +237,9 @@ struct rcu_stress {
struct rcu_stress rcu_stress_array[RCU_STRESS_PIPE_LEN] = { { 0 } };
struct rcu_stress *rcu_stress_current;
int rcu_stress_idx;
-
int n_mberror;
+
+/* Updates protected by counts_mutex */
long long rcu_stress_count[RCU_STRESS_PIPE_LEN + 1];
--
2.20.1
- [PULL 00/19] testing and plugin updates, Alex Bennée, 2020/02/26
- [PULL 01/19] tests/tcg: include a skip runner for pauth3 with plugins, Alex Bennée, 2020/02/26
- [PULL 02/19] tests/rcutorture: update usage hint, Alex Bennée, 2020/02/26
- [PULL 03/19] tests/rcutorture: better document locking of stats,
Alex Bennée <=
- [PULL 04/19] tests/rcutorture: mild documenting refactor of update thread, Alex Bennée, 2020/02/26
- [PULL 05/19] travis.yml: Test the s390-ccw build, too, Alex Bennée, 2020/02/26
- [PULL 06/19] travis.yml: Fix Travis YAML configuration warnings, Alex Bennée, 2020/02/26
- [PULL 07/19] travis.yml: single-thread build-tcg stages, Alex Bennée, 2020/02/26
- [PULL 08/19] tests/iotests: be a little more forgiving on the size test, Alex Bennée, 2020/02/26
- [PULL 09/19] tracing: only allow -trace to override -D if set, Alex Bennée, 2020/02/26
- [PULL 10/19] docs/devel: document query handle lifetimes, Alex Bennée, 2020/02/26
- [PULL 11/19] plugins/core: add missing break in cb_to_tcg_flags, Alex Bennée, 2020/02/26
- [PULL 12/19] tests/plugin: prevent uninitialized warning, Alex Bennée, 2020/02/26
- [PULL 13/19] qemu/bitops.h: Add extract8 and extract16, Alex Bennée, 2020/02/26