[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/19] tests/plugin: prevent uninitialized warning
From: |
Alex Bennée |
Subject: |
[PULL 12/19] tests/plugin: prevent uninitialized warning |
Date: |
Wed, 26 Feb 2020 07:39:22 +0000 |
From: Chen Qun <address@hidden>
According to the glibc function requirements, we need initialise
the variable. Otherwise there will be compilation warnings:
glib-autocleanups.h:28:3: warning: ‘out’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
g_free (*pp);
^~~~~~~~~~~~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
[AJB: uses Thomas's single line allocation]
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
diff --git a/tests/plugin/bb.c b/tests/plugin/bb.c
index f30bea08dcc..df19fd359df 100644
--- a/tests/plugin/bb.c
+++ b/tests/plugin/bb.c
@@ -22,9 +22,9 @@ static bool do_inline;
static void plugin_exit(qemu_plugin_id_t id, void *p)
{
- g_autofree gchar *out;
- out = g_strdup_printf("bb's: %" PRIu64", insns: %" PRIu64 "\n",
- bb_count, insn_count);
+ g_autofree gchar *out = g_strdup_printf(
+ "bb's: %" PRIu64", insns: %" PRIu64 "\n",
+ bb_count, insn_count);
qemu_plugin_outs(out);
}
diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c
index 0a8f5a0000e..a9a6e412373 100644
--- a/tests/plugin/insn.c
+++ b/tests/plugin/insn.c
@@ -44,8 +44,7 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct
qemu_plugin_tb *tb)
static void plugin_exit(qemu_plugin_id_t id, void *p)
{
- g_autofree gchar *out;
- out = g_strdup_printf("insns: %" PRIu64 "\n", insn_count);
+ g_autofree gchar *out = g_strdup_printf("insns: %" PRIu64 "\n",
insn_count);
qemu_plugin_outs(out);
}
--
2.20.1
- [PULL 02/19] tests/rcutorture: update usage hint, (continued)
- [PULL 02/19] tests/rcutorture: update usage hint, Alex Bennée, 2020/02/26
- [PULL 03/19] tests/rcutorture: better document locking of stats, Alex Bennée, 2020/02/26
- [PULL 04/19] tests/rcutorture: mild documenting refactor of update thread, Alex Bennée, 2020/02/26
- [PULL 05/19] travis.yml: Test the s390-ccw build, too, Alex Bennée, 2020/02/26
- [PULL 06/19] travis.yml: Fix Travis YAML configuration warnings, Alex Bennée, 2020/02/26
- [PULL 07/19] travis.yml: single-thread build-tcg stages, Alex Bennée, 2020/02/26
- [PULL 08/19] tests/iotests: be a little more forgiving on the size test, Alex Bennée, 2020/02/26
- [PULL 09/19] tracing: only allow -trace to override -D if set, Alex Bennée, 2020/02/26
- [PULL 10/19] docs/devel: document query handle lifetimes, Alex Bennée, 2020/02/26
- [PULL 11/19] plugins/core: add missing break in cb_to_tcg_flags, Alex Bennée, 2020/02/26
- [PULL 12/19] tests/plugin: prevent uninitialized warning,
Alex Bennée <=
- [PULL 13/19] qemu/bitops.h: Add extract8 and extract16, Alex Bennée, 2020/02/26
- [PULL 14/19] target/riscv: progressively load the instruction during decode, Alex Bennée, 2020/02/26
- [PULL 17/19] tcg: save vaddr temp for plugin usage, Alex Bennée, 2020/02/26
- [PULL 19/19] tests/tcg: take into account expected clashes pauth-4, Alex Bennée, 2020/02/26
- [PULL 15/19] tests/plugins: make howvec clean-up after itself., Alex Bennée, 2020/02/26
- [PULL 18/19] tests/tcg: fix typo in configure.sh test for v8.3, Alex Bennée, 2020/02/26
- [PULL 16/19] tests/tcg: give debug builds a little bit longer, Alex Bennée, 2020/02/26
- Re: [PULL 00/19] testing and plugin updates, Peter Maydell, 2020/02/27