[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/9] iotests: add script_initialize
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH v6 2/9] iotests: add script_initialize |
|
Date: |
Thu, 27 Feb 2020 14:47:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 27.02.20 01:06, John Snow wrote:
> Like script_main, but doesn't require a single point of entry.
> Replace all existing initialization sections with this drop-in replacement.
>
> This brings debug support to all existing script-style iotests.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/149 | 3 +-
> tests/qemu-iotests/194 | 4 +-
> tests/qemu-iotests/202 | 4 +-
> tests/qemu-iotests/203 | 4 +-
> tests/qemu-iotests/206 | 2 +-
> tests/qemu-iotests/207 | 6 ++-
> tests/qemu-iotests/208 | 2 +-
> tests/qemu-iotests/209 | 2 +-
> tests/qemu-iotests/210 | 6 ++-
> tests/qemu-iotests/211 | 6 ++-
> tests/qemu-iotests/212 | 6 ++-
> tests/qemu-iotests/213 | 6 ++-
> tests/qemu-iotests/216 | 4 +-
> tests/qemu-iotests/218 | 2 +-
> tests/qemu-iotests/219 | 2 +-
> tests/qemu-iotests/222 | 7 ++--
> tests/qemu-iotests/224 | 4 +-
> tests/qemu-iotests/228 | 6 ++-
> tests/qemu-iotests/234 | 4 +-
> tests/qemu-iotests/235 | 4 +-
> tests/qemu-iotests/236 | 2 +-
> tests/qemu-iotests/237 | 2 +-
> tests/qemu-iotests/238 | 2 +
> tests/qemu-iotests/242 | 2 +-
> tests/qemu-iotests/246 | 2 +-
> tests/qemu-iotests/248 | 2 +-
> tests/qemu-iotests/254 | 2 +-
> tests/qemu-iotests/255 | 2 +-
> tests/qemu-iotests/256 | 2 +-
> tests/qemu-iotests/258 | 7 ++--
> tests/qemu-iotests/260 | 4 +-
> tests/qemu-iotests/262 | 4 +-
> tests/qemu-iotests/264 | 4 +-
> tests/qemu-iotests/277 | 2 +
> tests/qemu-iotests/280 | 8 ++--
> tests/qemu-iotests/283 | 4 +-
> tests/qemu-iotests/iotests.py | 73 +++++++++++++++++++++++------------
> 37 files changed, 128 insertions(+), 80 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
[...]
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index e8a0ea14fc..fdcf8a940c 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
[...]
> @@ -1092,13 +1105,18 @@ def execute_unittest(output, verbosity, debug):
>
> sys.stderr.write(out)
>
> -def execute_test(test_function=None,
> - supported_fmts=[],
> - supported_platforms=None,
> - supported_cache_modes=[], supported_aio_modes={},
> - unsupported_fmts=[], supported_protocols=[],
> - unsupported_protocols=[]):
> - """Run either unittest or script-style tests."""
> +def execute_setup_common(supported_fmts: Collection[str] = (),
First time I see something like this, but I suppose it means any
collection (i.e. list or tuple in this case) that has str values?
Max
> + supported_platforms: Collection[str] = (),
> + supported_cache_modes: Collection[str] = (),
> + supported_aio_modes: Collection[str] = (),
> + unsupported_fmts: Collection[str] = (),
> + supported_protocols: Collection[str] = (),
> + unsupported_protocols: Collection[str] = ()) ->
> bool:
signature.asc
Description: OpenPGP digital signature
- [PATCH v6 3/9] iotests: replace mutable list default args, (continued)
- [PATCH v6 3/9] iotests: replace mutable list default args, John Snow, 2020/02/26
- [PATCH v6 4/9] iotest 258: use script_main, John Snow, 2020/02/26
- [PATCH v6 5/9] iotests: Mark verify functions as private, John Snow, 2020/02/26
- [PATCH v6 7/9] iotests: ignore import warnings from pylint, John Snow, 2020/02/26
- [PATCH v6 2/9] iotests: add script_initialize, John Snow, 2020/02/26
- Re: [PATCH v6 2/9] iotests: add script_initialize,
Max Reitz <=
- [PATCH v6 6/9] iotests: use python logging for iotests.log(), John Snow, 2020/02/26
- [PATCH v6 8/9] iotests: don't use 'format' for drive_add, John Snow, 2020/02/26
- [PATCH v6 1/9] iotests: do a light delinting, John Snow, 2020/02/26
- [PATCH v6 9/9] iotests: add pylintrc file, John Snow, 2020/02/26