[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 4/8] iotests: filter out compression_type
From: |
Eric Blake |
Subject: |
Re: [PATCH v1 4/8] iotests: filter out compression_type |
Date: |
Thu, 27 Feb 2020 08:03:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 2/27/20 1:29 AM, Denis Plotnikov wrote:
After adding compression type feature to qcow2 format, qemu framework
commands reporting the image settingd, e.g. "qemu-img create", started
settings
reporting the compression type for the image which breaks the iotests
output matching.
To fix it, add compression_type=zlib to the list of filtered image parameters.
Signed-off-by: Denis Plotnikov <address@hidden>
---
tests/qemu-iotests/common.filter | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
This should be squashed in to the patch that caused the breakage (3/8,
if I'm right).
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index 3f8ee3e5f7..c6962d199c 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
@@ -152,7 +152,8 @@ _filter_img_create()
-e "s# refcount_bits=[0-9]\\+##g" \
-e "s# key-secret=[a-zA-Z0-9]\\+##g" \
-e "s# iter-time=[0-9]\\+##g" \
- -e "s# force_size=\\(on\\|off\\)##g"
+ -e "s# force_size=\\(on\\|off\\)##g" \
+ -e "s# compression_type=zlib##g"
Do you really want to hard-code just zlib, or should this be more
generic as compression_type=[a-zA-Z0-9]\\+ as done on other lines like
key-secret?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v1 3/8] qcow2: add zstd cluster compression, (continued)
Re: [PATCH v1 3/8] qcow2: add zstd cluster compression, Eric Blake, 2020/02/27
[PATCH v1 2/8] qcow2: rework the cluster compression routine, Denis Plotnikov, 2020/02/27
[PATCH v1 4/8] iotests: filter out compression_type, Denis Plotnikov, 2020/02/27
[PATCH v1 6/8] iotests: add "compression type" for test output matching, Denis Plotnikov, 2020/02/27
[PATCH v1 5/8] iotests: fix header size, feature table size and backing file offset, Denis Plotnikov, 2020/02/27
[PATCH v1 1/8] qcow2: introduce compression type feature, Denis Plotnikov, 2020/02/27