[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] savevm: check RAM is pagesize aligned
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 3/3] savevm: check RAM is pagesize aligned |
|
Date: |
Fri, 28 Feb 2020 08:55:16 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Aleksandar Markovic <address@hidden> wrote:
> On Thursday, February 27, 2020, Juan Quintela <address@hidden> wrote:
>
> Marc-André Lureau <address@hidden> wrote:
> > Hi Juan
> >
> > On Wed, Jan 8, 2020 at 2:08 PM Juan Quintela <address@hidden> wrote:
> >>
> >> Marc-André Lureau <address@hidden> wrote:
> >> n> Check the host pointer is correctly aligned, otherwise we may fail
> >> > during migration in ram_block_discard_range().
> >> >
> >> > Signed-off-by: Marc-André Lureau <address@hidden>
> >>
> >> Reviewed-by: Juan Quintela <address@hidden>
> >>
> >> queued
> >>
> >
> > Did it get lost? thanks
>
> I dropped it in the past, because it made "make check" for mips fail.
> (I put it on my ToDo list to investigate and forgot about it)
>
> Thank you for caring for mips.
You are welcome.
But you need to thank "make check"
It didn't pass.
> Do you perhaps remember what was tgevtest and environment for the failing
> test?
It was plain "make check" with everything under the sun compiled in.
Clearly it was other of the patches, or an interaction between them what
failed.
I don't remember the error, sorry. I droped the patch to my ToDo list
of things to investigate (the patch was "obviously" correct) and forgot
about it.
Later, Juan.