[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h"
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h" |
Date: |
Fri, 28 Feb 2020 12:46:46 +0100 |
Both ich9.c and piix4.c use methods/definitions declared in the
NVDIMM device header. Include it.
This fixes (when modifying unrelated headers):
hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/ich9.c:508:13: error: implicit declaration of function
'nvdimm_acpi_plug_cb' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
hw/acpi/piix4.c:403:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/piix4.c:404:13: error: implicit declaration of function
'nvdimm_acpi_plug_cb' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/acpi/ich9.c | 1 +
hw/acpi/piix4.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index fdd0a6c79e..4e74284b65 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -39,6 +39,7 @@
#include "hw/i386/ich9.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
//#define DEBUG
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 6d621c31e7..b84dbba2c3 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -38,6 +38,7 @@
#include "hw/acpi/cpu.h"
#include "hw/hotplug.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
#include "hw/acpi/memory_hotplug.h"
#include "hw/acpi/acpi_dev_interface.h"
#include "hw/xen/xen.h"
--
2.21.1
- Re: [PATCH v2 05/18] hw/usb/dev-storage: Remove unused "ui/console.h" header, (continued)
- [PATCH v2 07/18] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 06/18] hw/i386/intel_iommu: Remove unused includes, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 09/18] hw/hppa/machine: Include "net/net.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 11/18] hw/timer/hpet: Include "exec/address-spaces.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 10/18] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 12/18] hw/pci-host/q35: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 13/18] hw/i2c/smbus_ich9: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h",
Philippe Mathieu-Daudé <=
- [PATCH v2 18/18] hw/i386/pc: Clean up includes, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 16/18] hw/i386: Include "hw/mem/nvdimm.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 17/18] hw/pci-host/q35: Remove unused includes, Philippe Mathieu-Daudé, 2020/02/28
- Re: [PATCH v2 00/18] hw: Clean up hw/i386 headers (and few alpha/hppa), Richard Henderson, 2020/02/29