|
From: | Liam Merwick |
Subject: | Re: [PATCH] block: Remove trailing newline in format used by error_report API |
Date: | Fri, 28 Feb 2020 13:16:33 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 28/02/2020 12:36, Philippe Mathieu-Daudé wrote:
The error_report API doesn't want trailing newline characters. Remove it, to avoid and error when moving the code around:
s/and/an/
ERROR: Error messages should not contain newlines Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Liam Merwick <address@hidden>
--- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 1bdb9c679d..e466d15914 100644 --- a/block.c +++ b/block.c @@ -5994,7 +5994,7 @@ void bdrv_img_create(const char *filename, const char *fmt, /* Couldn't open BS, but we have a size, so it's nonfatal */ warn_reportf_err(local_err, "Could not verify backing image. " - "This may become an error in future versions.\n"); + "This may become an error in future versions."); local_err = NULL; } else if (!bs) { /* Couldn't open bs, do not have size */
[Prev in Thread] | Current Thread | [Next in Thread] |