[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] i386: Fix GCC warning with snprintf when HAX is enabled
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2] i386: Fix GCC warning with snprintf when HAX is enabled |
|
Date: |
Sun, 1 Mar 2020 20:16:47 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/1/20 11:17 AM, Julio Faracco wrote:
> - snprintf(name, sizeof HAX_VM_DEVFS, "/dev/hax_vm/vm%02d", vm_id);
> + assert(vm_id < 0);
> +
> + if (snprintf(name, sizeof HAX_VM_DEVFS, "/dev/hax_vm/vm%02d",
> + vm_id) < 0)
> + return NULL;
> +
And the assert is opposite. You didn't even smoke test.
r~