|
From: | Tao Xu |
Subject: | Re: [PATCH v3 2/4] target/i386: Remove monitor from some CPU models |
Date: | Mon, 2 Mar 2020 19:47:28 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 2/29/2020 5:39 AM, Eduardo Habkost wrote:
On Wed, Feb 12, 2020 at 04:13:26PM +0800, Tao Xu wrote:Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana CPU model to uremove MONITOR/MWAIT featre. After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT (commit id 6f131f13e68d648a8e4f083c667ab1acd88ce4cd), the MONITOR/MWAIT feature in these CPU model is unused. Signed-off-by: Tao Xu <address@hidden>What exactly is the problem you are trying to fix? No CPU model will ever have monitor=on set by default with KVM, because kvm_default_props has a monitor=off element.
Maybe it is not a fix. For example, when we boot a guest with Denvertoncpu model, guest cannot detect MONITOR/MWAIT and boot with no warning, because of "monitor=off" by default. The MONITOR/MWAIT feature in these CPU model is unused,but no harm. I am wondering if we should remove it from existing CPU models.
[Prev in Thread] | Current Thread | [Next in Thread] |