[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/5] Revert "vfio/pci: Disable INTx fast path if using spl
From: |
Auger Eric |
Subject: |
Re: [PATCH v2 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip" |
Date: |
Mon, 2 Mar 2020 16:10:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Peter,
On 2/28/20 5:15 PM, Peter Xu wrote:
> With the resamplefd list introduced, we can savely enable VFIO INTx
> fast path again with split irqchip so it can still be faster than the
> complete slow path.
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Thanks
Eric
> ---
> hw/vfio/pci.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 09703362df..1c0aa27386 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -124,18 +124,6 @@ static void vfio_intx_enable_kvm(VFIOPCIDevice *vdev,
> Error **errp)
> return;
> }
>
> - if (kvm_irqchip_is_split()) {
> - /*
> - * VFIO INTx is currently not working with split kernel
> - * irqchip for level triggered interrupts. Go the slow path
> - * as long as split is enabled so we can be at least
> - * functional (even with poor performance).
> - *
> - * TODO: Remove this after all things fixed up.
> - */
> - return;
> - }
> -
> /* Get to a known interrupt state */
> qemu_set_fd_handler(irq_fd, NULL, NULL, vdev);
> vfio_mask_single_irqindex(&vdev->vbasedev, VFIO_PCI_INTX_IRQ_INDEX);
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip",
Auger Eric <=