Re: [PATCH] tests/acceptance: move @skipUnless decoration to test itself

[Philippe Mathieu-Daudé]

On 3/2/20 7:09 PM, Alex Bennée wrote:
> It appears ignore the decoration if just applied to the class.

Odd I remember testing this, this might be a feature supported by a 
newer Avocado version than the one available on Travis-CI.

> Signed-off-by: Alex Bennée <address@hidden>
> ---
>   tests/acceptance/machine_mips_malta.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/machine_mips_malta.py 
> b/tests/acceptance/machine_mips_malta.py
> index 92b4f28a112..b8fac2a44d5 100644
> --- a/tests/acceptance/machine_mips_malta.py
> +++ b/tests/acceptance/machine_mips_malta.py
> @@ -30,14 +30,14 @@ except ImportError:
>       CV2_AVAILABLE = False
>   
>   
> -@skipUnless(NUMPY_AVAILABLE, 'Python NumPy not installed')
> -@skipUnless(CV2_AVAILABLE, 'Python OpenCV not installed')
>   class MaltaMachineFramebuffer(Test):
>   
>       timeout = 30
>   
>       KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
>   
> +    @skipUnless(NUMPY_AVAILABLE, 'Python NumPy not installed')
> +    @skipUnless(CV2_AVAILABLE, 'Python OpenCV not installed')
>       def do_test_i6400_framebuffer_logo(self, cpu_cores_count):
>           """
>           Boot Linux kernel and check Tux logo is displayed on the framebuffer.

Unfortunately you have to also add it to the 7/8cores tests.