[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/5] mostly changes related to audio float samples
From: |
Volker Rümelin |
Subject: |
[PATCH 0/5] mostly changes related to audio float samples |
Date: |
Mon, 2 Mar 2020 20:08:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Patch "audio: change naming scheme of FLOAT_CONV macros" and
patch "audio: consistency changes" should have been a review
for ed2a4a7941 "audio: proper support for float samples in
mixeng", but I was too slow.
Patch "audio: change mixing engine float range to [-1.f, 1.f]"
definitely needs to be tested by macOS users. I verified
PulseAudio, SDL2 and ALSA (actually libasound) work, but I
don't want to introduce a regression for CoreAudio. I spent
some time on https://developer.apple.com but I couldn't find
the answer if CoreAudio uses the [-1.f, 1.f] range too. The
results from my favorite search engine suggest the answer is
yes.
@Howard:
I need your help once again. Can you please test if you can
hear (or see) clipping with my patches? Don't forget to set all
volume controls in the guest and on the host to 100% or 0dB to
get a reliable result. Compared to qemu without these patches I
expect the playback volume is a bit louder, but there's still
no clipping.
Volker Rümelin (5):
qapi/audio: add documentation for AudioFormat
audio: change naming scheme of FLOAT_CONV macros
audio: consistency changes
audio: change mixing engine float range to [-1.f, 1.f]
audio: fix saturation nonlinearity in clip_* functions
audio/mixeng.c | 26 +++++++++++++-------------
audio/mixeng_template.h | 22 ++++++++++------------
qapi/audio.json | 14 ++++++++++++++
3 files changed, 37 insertions(+), 25 deletions(-)
--
2.16.4
- [PATCH 0/5] mostly changes related to audio float samples,
Volker Rümelin <=
- [PATCH 1/5] qapi/audio: add documentation for AudioFormat, Volker Rümelin, 2020/03/02
- [PATCH 4/5] audio: change mixing engine float range to [-1.f, 1.f], Volker Rümelin, 2020/03/02
- [PATCH 2/5] audio: change naming scheme of FLOAT_CONV macros, Volker Rümelin, 2020/03/02
- [PATCH 3/5] audio: consistency changes, Volker Rümelin, 2020/03/02
- [PATCH 5/5] audio: fix saturation nonlinearity in clip_* functions, Volker Rümelin, 2020/03/02
- Re: [PATCH 0/5] mostly changes related to audio float samples, Howard Spoelstra, 2020/03/02