qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/15] util/mmap-alloc: Factor out populating of memory to


From: David Hildenbrand
Subject: Re: [PATCH v3 09/15] util/mmap-alloc: Factor out populating of memory to mmap_populate()
Date: Tue, 3 Mar 2020 09:43:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 27.02.20 11:11, David Hildenbrand wrote:
> We want to populate memory within a reserved memory region. Let's factor
> that out.
> 
> Reviewed-by: Richard Henderson <address@hidden>
> Acked-by: Murilo Opsfelder Araujo <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
> Cc: Igor Kotrasinski <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Greg Kurz <address@hidden>
> Cc: Murilo Opsfelder Araujo <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>

Thought a bit longer about the terminology (as brought up by Peter).
Populate might indeed be confusing, because we are not actually
populating all memory (e.g., MAP_POPULATE). We enable/activate the
mapping to be accessible.

Hmmm

mmap_enable() ?

mmap_activate() ?

I think I like the latter. Alternatives?

-- 
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]