[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC 1/4] openpic_kvm: Use kvm_device_ioctl() instead of ioctl()
From: |
David Hildenbrand |
Subject: |
[PATCH RFC 1/4] openpic_kvm: Use kvm_device_ioctl() instead of ioctl() |
Date: |
Tue, 3 Mar 2020 15:19:36 +0100 |
Let's use the official variant, which will e.g., trace the call.
Cc: Markus Armbruster <address@hidden>
Cc: "Philippe Mathieu-Daudé" <address@hidden>
Cc: "Marc-André Lureau" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/intc/openpic_kvm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
index e4bf47d885..0d8abc1604 100644
--- a/hw/intc/openpic_kvm.c
+++ b/hw/intc/openpic_kvm.c
@@ -70,7 +70,7 @@ static void kvm_openpic_write(void *opaque, hwaddr addr,
uint64_t val,
attr.attr = addr;
attr.addr = (uint64_t)(unsigned long)&val32;
- ret = ioctl(opp->fd, KVM_SET_DEVICE_ATTR, &attr);
+ ret = kvm_device_ioctl(opp->fd, KVM_SET_DEVICE_ATTR, &attr);
if (ret < 0) {
qemu_log_mask(LOG_UNIMP, "%s: %s %" PRIx64 "\n", __func__,
strerror(errno), attr.attr);
@@ -96,7 +96,7 @@ static uint64_t kvm_openpic_read(void *opaque, hwaddr addr,
unsigned size)
attr.attr = addr;
attr.addr = (uint64_t)(unsigned long)&val;
- ret = ioctl(opp->fd, KVM_GET_DEVICE_ATTR, &attr);
+ ret = kvm_device_ioctl(opp->fd, KVM_GET_DEVICE_ATTR, &attr);
if (ret < 0) {
qemu_log_mask(LOG_UNIMP, "%s: %s %" PRIx64 "\n", __func__,
strerror(errno), attr.attr);
@@ -145,7 +145,7 @@ static void kvm_openpic_region_add(MemoryListener *listener,
attr.attr = KVM_DEV_MPIC_BASE_ADDR;
attr.addr = (uint64_t)(unsigned long)®_base;
- ret = ioctl(opp->fd, KVM_SET_DEVICE_ATTR, &attr);
+ ret = kvm_device_ioctl(opp->fd, KVM_SET_DEVICE_ATTR, &attr);
if (ret < 0) {
fprintf(stderr, "%s: %s %" PRIx64 "\n", __func__,
strerror(errno), reg_base);
@@ -179,7 +179,7 @@ static void kvm_openpic_region_del(MemoryListener *listener,
attr.attr = KVM_DEV_MPIC_BASE_ADDR;
attr.addr = (uint64_t)(unsigned long)®_base;
- ret = ioctl(opp->fd, KVM_SET_DEVICE_ATTR, &attr);
+ ret = kvm_device_ioctl(opp->fd, KVM_SET_DEVICE_ATTR, &attr);
if (ret < 0) {
fprintf(stderr, "%s: %s %" PRIx64 "\n", __func__,
strerror(errno), reg_base);
--
2.24.1