Re: [PATCH 0/3] hw/net,virtfs-proxy-helper: Reduce .data footprint

[Philippe Mathieu-Daudé]

On 3/5/20 10:53 AM, Stefano Garzarella wrote:
> On Thu, Mar 05, 2020 at 02:04:43AM +0100, Philippe Mathieu-Daudé wrote:
> > More memory footprint reduction, similar to:
> > https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg00984.html
> >
> > The elf-dissector tool [1] [2] helped to notice the big array.
> >
> > [1] https://phabricator.kde.org/source/elf-dissector/
> > [2] https://www.volkerkrause.eu/2019/06/22/elf-dissector-aarch64-support.html
>
> Thanks to share these links!

FYI the heap equivalent (besides that more powerful) is:
https://github.com/KDE/heaptrack

> > Philippe Mathieu-Daudé (3):
> >    hw/net/e1000: Add readops/writeops typedefs
> >    hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
> >    virtfs-proxy-helper: Make the helper_opts[] array const
> >
> >   fsdev/virtfs-proxy-helper.c | 2 +-
> >   hw/net/e1000.c              | 6 ++++--
> >   hw/net/e1000e_core.c        | 6 ++++--
> >   3 files changed, 9 insertions(+), 5 deletions(-)
>
> Cool and clear changes!
>
> Reviewed-by: Stefano Garzarella <address@hidden>
>
> Thanks,
> Stefano