Re: [RFC PATCH] tools/virtiofsd: add support for --socket-group

[Stefan Hajnoczi]

On Wed, Mar 04, 2020 at 06:50:25PM +0000, Alex Bennée wrote:
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 378594c422a..6d2342f74d4 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -85,6 +85,10 @@ Options
>  
>    Listen on vhost-user UNIX domain socket at PATH.
>  
> +.. option:: --socket-group=GROUP
> +
> +  Also make vhost-user UNIX domain socket accessible to GROUP.

Files only have one gid but the above sentence can be interpreted as
"add GROUP" (instead of "set GROUP").  Please drop "Also" to make the
meaning clearer.

> @@ -924,15 +926,29 @@ static int fv_create_listen_socket(struct fuse_session 
> *se)
>  
>      /*
>       * Unfortunately bind doesn't let you set the mask on the socket,
> -     * so set umask to 077 and restore it later.
> +     * so set umask to appropriately and restore it later.

s/ to //

signature.asc
Description: PGP signature