Re: [PATCH] 9p/proxy: Fix export_flags

[Christian Schoenebeck]

On Freitag, 6. März 2020 13:05:37 CET Greg Kurz wrote:
> The common fsdev options are set by qemu_fsdev_add() before it calls
> the backend specific option parsing code. In the case of "proxy" this
> means "writeout" or "readonly" were simply ignored. This has been
> broken from the beginning.
> 
> Signed-off-by: Greg Kurz <address@hidden>

Reviewed-by: Christian Schoenebeck <address@hidden>

> ---
>  hw/9pfs/9p-proxy.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
> index 8136e1342d78..6f598a0f111c 100644
> --- a/hw/9pfs/9p-proxy.c
> +++ b/hw/9pfs/9p-proxy.c
> @@ -1139,10 +1139,10 @@ static int proxy_parse_opts(QemuOpts *opts,
> FsDriverEntry *fs, Error **errp) }
>      if (socket) {
>          fs->path = g_strdup(socket);
> -        fs->export_flags = V9FS_PROXY_SOCK_NAME;
> +        fs->export_flags |= V9FS_PROXY_SOCK_NAME;
>      } else {
>          fs->path = g_strdup(sock_fd);
> -        fs->export_flags = V9FS_PROXY_SOCK_FD;
> +        fs->export_flags |= V9FS_PROXY_SOCK_FD;
>      }
>      return 0;
>  }