Re: [PATCH v3 2/2] cmd646: remove unused pci_cmd646_ide_init() function

[Philippe Mathieu-Daudé]

On 3/7/20 10:13 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> ---
>   hw/ide/cmd646.c  | 12 ------------
>   include/hw/ide.h |  2 --
>   2 files changed, 14 deletions(-)
>
> diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
> index 335c060673..d953932104 100644
> --- a/hw/ide/cmd646.c
> +++ b/hw/ide/cmd646.c
> @@ -317,18 +317,6 @@ static void pci_cmd646_ide_exitfn(PCIDevice *dev)
>       }
>   }
>   
> -void pci_cmd646_ide_init(PCIBus *bus, DriveInfo **hd_table,
> -                         int secondary_ide_enabled)
> -{
> -    PCIDevice *dev;
> -
> -    dev = pci_create(bus, -1, "cmd646-ide");
> -    qdev_prop_set_uint32(&dev->qdev, "secondary", secondary_ide_enabled);
> -    qdev_init_nofail(&dev->qdev);
> -
> -    pci_ide_create_devs(dev, hd_table);
> -}
> -
>   static Property cmd646_ide_properties[] = {
>       DEFINE_PROP_UINT32("secondary", PCIIDEState, secondary, 0),
>       DEFINE_PROP_END_OF_LIST(),
> diff --git a/include/hw/ide.h b/include/hw/ide.h
> index 28d8a06439..0c7080ed92 100644
> --- a/include/hw/ide.h
> +++ b/include/hw/ide.h
> @@ -12,8 +12,6 @@ ISADevice *isa_ide_init(ISABus *bus, int iobase, int iobase2, 
> int isairq,
>                           DriveInfo *hd0, DriveInfo *hd1);
>   
>   /* ide-pci.c */
> -void pci_cmd646_ide_init(PCIBus *bus, DriveInfo **hd_table,
> -                         int secondary_ide_enabled);
>   PCIDevice *pci_piix3_xen_ide_init(PCIBus *bus, DriveInfo **hd_table, int 
> devfn);
>   PCIDevice *pci_piix3_ide_init(PCIBus *bus, DriveInfo **hd_table, int devfn);
>   PCIDevice *pci_piix4_ide_init(PCIBus *bus, DriveInfo **hd_table, int devfn);

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>