[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in p
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() |
Date: |
Mon, 9 Mar 2020 13:32:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read
> format = 0;
> ^ ~
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> Cc: Andrzej Zaborowski <address@hidden>
> Cc: Peter Maydell <address@hidden>
> ---
> hw/display/pxa2xx_lcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c
> index 05f5f84671..464e93161a 100644
> --- a/hw/display/pxa2xx_lcd.c
> +++ b/hw/display/pxa2xx_lcd.c
> @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int
> ch, int bpp)
> n = 256;
> break;
> default:
> - format = 0;
> return;
> }
>
>
Reviewed-by: Laurent Vivier <address@hidden>
- [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), (continued)
- [PATCH v3 08/12] display/blizzard: Remove redundant statement in blizzard_draw_line16_32(), Chen Qun, 2020/03/02
- [PATCH v3 00/12] redundant code: Fix warnings reported by Clang static code analyzer, Chen Qun, 2020/03/02
- [PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Chen Qun, 2020/03/02
- [PATCH v3 01/12] block/stream: Remove redundant statement in stream_run(), Chen Qun, 2020/03/02
- [PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_open(), Chen Qun, 2020/03/02
[PATCH v3 07/12] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update(), Chen Qun, 2020/03/02