[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docs/devel/qapi-code-gen: Fix typo in grammar
From: |
John Snow |
Subject: |
Re: [PATCH] docs/devel/qapi-code-gen: Fix typo in grammar |
Date: |
Mon, 9 Mar 2020 10:44:12 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/9/20 10:26 AM, Markus Armbruster wrote:
> An ALTERNATIVE's value can only be a type name. Arrays are not
> supported, yet. The text gets it right: "The form STRING is shorthand
> for { 'type': STRING }." The grammar doesn't. Fix it.
>
> Fixes: b6c37ebaaf074cac8fe8a4781dc3e79db23e914e
> Reported-by: John Snow <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/devel/qapi-code-gen.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
> index 59d6973e1e..e73979e182 100644
> --- a/docs/devel/qapi-code-gen.txt
> +++ b/docs/devel/qapi-code-gen.txt
> @@ -399,7 +399,7 @@ Syntax:
> 'data': ALTERNATIVES,
> '*if': COND }
> ALTERNATIVES = { ALTERNATIVE, ... }
> - ALTERNATIVE = STRING : TYPE-REF
> + ALTERNATIVE = STRING : STRING
> | STRING : { 'type': STRING, '*if': COND }
>
> Member 'alternate' names the alternate type.
>
Danke :)
Reviewed-by: John Snow <address@hidden>