[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst
From: |
Laurent Vivier |
Subject: |
[PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() |
Date: |
Mon, 9 Mar 2020 16:08:33 +0100 |
From: Chen Qun <address@hidden>
Clang static code analyzer show warning:
hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/dma/xlnx-zdma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
index 1c1b142293a6..2d9c0a0d5e19 100644
--- a/hw/dma/xlnx-zdma.c
+++ b/hw/dma/xlnx-zdma.c
@@ -372,7 +372,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool
type,
static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
{
uint32_t dst_size, dlen;
- bool dst_intr, dst_type;
+ bool dst_intr;
unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
unsigned int rw_mode = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE);
unsigned int burst_type = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATTR,
@@ -386,17 +386,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf,
uint32_t len)
while (len) {
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
SIZE);
- dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
- TYPE);
if (dst_size == 0 && ptype == PT_MEM) {
uint64_t next;
+ bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
+ ZDMA_CH_DST_DSCR_WORD3,
+ TYPE);
+
next = zdma_update_descr_addr(s, dst_type,
R_ZDMA_CH_DST_CUR_DSCR_LSB);
zdma_load_descriptor(s, next, &s->dsc_dst);
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
SIZE);
- dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
- TYPE);
}
/* Match what hardware does by ignoring the dst_size and only using
--
2.24.1
- [PULL 16/33] hw/hppa/machine: Include "net/net.h", (continued)
- [PULL 16/33] hw/hppa/machine: Include "net/net.h", Laurent Vivier, 2020/03/09
- [PULL 25/33] hw/i386/pc: Clean up includes, Laurent Vivier, 2020/03/09
- [PULL 23/33] hw/i386: Include "hw/mem/nvdimm.h", Laurent Vivier, 2020/03/09
- [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), Laurent Vivier, 2020/03/09
- [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Laurent Vivier, 2020/03/09
- [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update(), Laurent Vivier, 2020/03/09
- [PULL 24/33] hw/pci-host/q35: Remove unused includes, Laurent Vivier, 2020/03/09
- [PULL 27/33] block/stream: Remove redundant statement in stream_run(), Laurent Vivier, 2020/03/09
- [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command(), Laurent Vivier, 2020/03/09
- [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), Laurent Vivier, 2020/03/09
- [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(),
Laurent Vivier <=
- Re: [PULL 00/33] Trivial branch patches, no-reply, 2020/03/09
- Re: [PULL 00/33] Trivial branch patches, Peter Maydell, 2020/03/09
- Re: [PULL 00/33] Trivial branch patches, Michael S. Tsirkin, 2020/03/09
- Re: [PULL 00/33] Trivial branch patches, Philippe Mathieu-Daudé, 2020/03/09
- Re: [PULL 00/33] Trivial branch patches, Laurent Vivier, 2020/03/10
- Re: [PULL 00/33] Trivial branch patches, Kevin Wolf, 2020/03/10
- Re: [PULL 00/33] Trivial branch patches, Philippe Mathieu-Daudé, 2020/03/10
- Re: [PULL 00/33] Trivial branch patches, Daniel P . Berrangé, 2020/03/10
- Re: [PULL 00/33] Trivial branch patches, Kevin Wolf, 2020/03/10
- Re: [PULL 00/33] Trivial branch patches, Philippe Mathieu-Daudé, 2020/03/10