[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
From: |
no-reply |
Subject: |
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements |
Date: |
Mon, 9 Mar 2020 19:04:14 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e612415 hw/i386/vmport: Assert vmport initialized before registering commands
9aad846 hw/i386/vmport: Add support for CMD_GETHZ
de3b721 i386/cpu: Store LAPIC bus frequency in CPU structure
25cba27 hw/i386/vmport: Allow x2apic without IR
f779fc6 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO
42ff7b9 hw/i386/vmport: Add support for CMD_GETTIMEFULL
1df74aa hw/i386/vmport: Add support for CMD_GETTIME
bef18ba hw/i386/vmport: Add support for CMD_GETBIOSUUID
8d00a31 hw/i386/vmport: Define enum for all commands
59dd012 hw/i386/vmport: Report VMX type in CMD_GETVERSION
9d6dcf5 hw/i386/vmport: Introduce vmx-version property
83c777e hw/i386/vmport: Add device properties
76c35fd hw/i386/vmport: Set EAX to -1 on failed and unsupported commands
3415e5c hw/i386/vmport: Propagate IOPort read to vCPU EAX register
=== OUTPUT BEGIN ===
1/14 Checking commit 3415e5c8f2bb (hw/i386/vmport: Propagate IOPort read to
vCPU EAX register)
2/14 Checking commit 76c35fd191ac (hw/i386/vmport: Set EAX to -1 on failed and
unsupported commands)
3/14 Checking commit 83c777e525f3 (hw/i386/vmport: Add device properties)
4/14 Checking commit 9d6dcf5f85dc (hw/i386/vmport: Introduce vmx-version
property)
5/14 Checking commit 59dd012575b6 (hw/i386/vmport: Report VMX type in
CMD_GETVERSION)
6/14 Checking commit 8d00a315ff15 (hw/i386/vmport: Define enum for all commands)
7/14 Checking commit bef18baf157e (hw/i386/vmport: Add support for
CMD_GETBIOSUUID)
ERROR: "(foo*)" should be "(foo *)"
#33: FILE: hw/i386/vmport.c:128:
+ uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data);
total: 1 errors, 0 warnings, 39 lines checked
Patch 7/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/14 Checking commit 1df74aaccdd2 (hw/i386/vmport: Add support for CMD_GETTIME)
9/14 Checking commit 42ff7b94f787 (hw/i386/vmport: Add support for
CMD_GETTIMEFULL)
10/14 Checking commit f779fc608aac (hw/i386/vmport: Add support for
CMD_GET_VCPU_INFO)
ERROR: return is not a function, parentheses are not required
#41: FILE: hw/i386/vmport.c:185:
+ return (1 << VCPU_INFO_RESERVED_BIT);
total: 1 errors, 0 warnings, 38 lines checked
Patch 10/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/14 Checking commit 25cba27733da (hw/i386/vmport: Allow x2apic without IR)
12/14 Checking commit de3b7215948c (i386/cpu: Store LAPIC bus frequency in CPU
structure)
13/14 Checking commit 9aad8462bcc2 (hw/i386/vmport: Add support for CMD_GETHZ)
14/14 Checking commit e612415198f4 (hw/i386/vmport: Assert vmport initialized
before registering commands)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID, (continued)
- [PATCH 08/14] hw/i386/vmport: Add support for CMD_GETTIME, Liran Alon, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements,
no-reply <=
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09
- Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements, no-reply, 2020/03/09