qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency


From: Laurent Vivier
Subject: Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency
Date: Tue, 10 Mar 2020 09:39:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

Le 09/03/2020 à 20:36, Unai Martinez Corral a écrit :
> 2020/3/9 20:30, Eric Blake:
> 
>     On 3/9/20 2:18 PM, Unai Martinez-Corral wrote:
>     > Spaces are removed before '; then', for consistency with other scripts
>     > in the project.
>     >
>     > Signed-off-by: Unai Martinez-Corral <address@hidden>
>     > Reviewed-by: Laurent Vivier <address@hidden
>     <mailto:address@hidden>>
> 
>     Technically, since this change is different than what Laurent
>     previously
>     reviewed, it might have been better to drop the R-b to make sure
>     everything is still okay.  But I'll let Laurent chime in, no need to
>     respin just yet.
> 
> 
> Thanks for clarifying. Honestly, I was not sure about how to proceed.
> 

Yes, it's better to drop the R-b if you change something that could
impact the review.

But this patch seems good, so you can let my R-b now.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]