Re: [PATCH 12/14] i386/cpu: Store LAPIC bus frequency in CPU structure

[Liran Alon]

On 10/03/2020 11:29, Michael S. Tsirkin wrote:
> On Tue, Mar 10, 2020 at 01:54:09AM +0200, Liran Alon wrote:
> > No functional change.
> > This information will be used by following patches.
> >
> > Reviewed-by: Nikita Leshenko <address@hidden>
> > Signed-off-by: Liran Alon <address@hidden>
> > ---
> >   linux-headers/asm-x86/kvm.h | 4 ++++
> >   target/i386/cpu.h           | 1 +
> >   target/i386/kvm.c           | 6 +++---
> >   3 files changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h
> > index 503d3f42da16..99eeaaf2f0b4 100644
> > --- a/linux-headers/asm-x86/kvm.h
> > +++ b/linux-headers/asm-x86/kvm.h
> > @@ -446,4 +446,8 @@ struct kvm_pmu_event_filter {
> >   #define KVM_PMU_EVENT_ALLOW 0
> >   #define KVM_PMU_EVENT_DENY 1
> >   
> > +/* From arch/x86/kvm/lapic.h */
> > +#define KVM_APIC_BUS_CYCLE_NS       1
> > +#define KVM_APIC_BUS_FREQUENCY      (1000000000ULL / KVM_APIC_BUS_CYCLE_NS)
> > +
> >   #endif /* _ASM_X86_KVM_H */
>
> This header is auto-generated from UAPI - you can't add
> your own stuff here.
Oh I didn't notice that. OK, I will move definitions to somewhere else.
Is it fine by you if I will just put them then in target/i386/kvm.c 
directly?
Or do you prefer I will put them in target/i386/kvm_i386.h

-Liran